NMS-17749: Zenith Connect UI, connect with Registration Rest API #7718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| registration.systemId.equals(existingRegistration.systemId); | ||
|
|
||
| if (systemIdsMatch) { | ||
| boolean accessTokenMatches = registration.accessToken != null && |
There was a problem hiding this comment.
For ZnithConnectRegistrations we are always getting first can you explain please? i don't understand it.
We have to avoid nested if else if possible.
There was a problem hiding this comment.
I pushed a change to remove some nesting.
For now, we only ever have just 1 registration. However, in case we add more in the future (maybe user connects with multiple Zenith instances or something else), I made the underlying data structure a list instead of a single object.
Shahbaz-dataq
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Zenith Connect UI to use the Rest API for storing and retrieving registration info.
Update the persistence service to exclude duplicate registrations.
Clean up the UI a bit.
External References